Skip to content

Fix boxplot stats for all-masked input - #32515

Open
mansi-tomar-sudo wants to merge 2 commits into
matplotlib:mainfrom
mansi-tomar-sudo:fix-boxplot-all-masked
Open

mansi-tomar-sudo wants to merge 2 commits into
matplotlib:mainfrom
mansi-tomar-sudo:fix-boxplot-all-masked

Conversation

@mansi-tomar-sudo

@mansi-tomar-sudo mansi-tomar-sudo commented Oct 21, 2026 •

Copy link
Copy Markdown

Summary

  • Handle inputs containing only masked values in boxplot_stats.
  • Add a regression test comparing the result with empty input.

Testing

  • python -m pytest lib/matplotlib/tests/test_cbook.py -k boxplot_stats — 13 passed.

AI Disclosure

I used ChatGPT to help understand the issue, review the proposed fix, and troubleshoot testing and contribution workflow. I reviewed the changes and ran the tests locally.

@github-actions

Copy link
Copy Markdown

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on discourse chat for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@lucaznch

Copy link
Copy Markdown
Contributor

Hello. Please fill out the pull request template and in particular the AI disclosure. Thank you!

@iccir

iccir commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Marking as an autoclose candidate since the PR template was not filled out correctly and precommit hooks were not run. Please fill out the PR template as @lucaznch mentioned, disclose any use of AI, and address the precommit failures. Thank you!

The test failures are unrelated and should be fixed by #32516.

@iccir iccir added the status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks label Oct 23, 2026
@github-actions

Copy link
Copy Markdown

⏰ This pull request might be automatically closed in two weeks from now.

Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable.

Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬

To increase the chance of a productive review:

As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code.

If you substantially improve this PR within two weeks, leave a comment and a team member may remove the status: autoclose candidate label and the PR stays open. Cosmetic changes or incomplete fixes will not be sufficient. Maintainers will assess improvements on their own schedule. Please do not ping (@) maintainers.

@mansi-tomar-sudo

Copy link
Copy Markdown
Author

Thanks for the feedback. I’ve completed the PR description template and added the AI disclosure. I also fixed the formatting issues and reran the relevant pre-commit hooks successfully. The focused tests pass locally: 13 passed.

Could the autoclose-candidate status be reviewed now?

@timhoffm timhoffm removed the status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks label Oct 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants