Repository navigation
Fix boxplot stats for all-masked input - #32515
mansi-tomar-sudo wants to merge 2 commits into
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
|
Hello. Please fill out the pull request template and in particular the AI disclosure. Thank you! |
|
Marking as an autoclose candidate since the PR template was not filled out correctly and precommit hooks were not run. Please fill out the PR template as @lucaznch mentioned, disclose any use of AI, and address the precommit failures. Thank you! The test failures are unrelated and should be fixed by #32516. |
|
⏰ This pull request might be automatically closed in two weeks from now. Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable. Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬 To increase the chance of a productive review:
As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code. If you substantially improve this PR within two weeks, leave a comment and a team member may remove the |
|
Thanks for the feedback. I’ve completed the PR description template and added the AI disclosure. I also fixed the formatting issues and reran the relevant pre-commit hooks successfully. The focused tests pass locally: Could the autoclose-candidate status be reviewed now? |
Summary
boxplot_stats.Testing
python -m pytest lib/matplotlib/tests/test_cbook.py -k boxplot_stats— 13 passed.AI Disclosure
I used ChatGPT to help understand the issue, review the proposed fix, and troubleshoot testing and contribution workflow. I reviewed the changes and ran the tests locally.