Repository navigation
Update dates.py - #32498
Update dates.py#32498MaddipatlaChetan24 wants to merge 2 commits into
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
github-actions
Bot
added
first-contribution
topic: date handling
AgentScan: automated
|
This PR shows indications of having been generated by AI, including the flag by AgentScan. Please check it against our policy and, if it complies, update the PR summary to use our template. This should including the AI disclosure and the PR quality checklist. At the moment the boxes that have been checked do not match what has actually been done. Neither is there an added regression test as stated in the summary. |
rcomer
added
the
status: autoclose candidate
|
⏰ This pull request might be automatically closed in two weeks from now. Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable. Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬 To increase the chance of a productive review:
As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code. If you substantially improve this PR within two weeks, leave a comment and a team member may remove the |
PR summary
drange()promises a half-open interval[dstart, dend), but when the requested span is an exact multiple ofdelta, floating-point error indate2num()'s day conversion can push the computed step count one too high. The existing singleifcorrection only backs off by one step, which isn't enough in this case, so the last returned point lands exactly ondendinstead of before it. Changed the singleifto awhileloop so it absorbs any amount of overshoot, not just one step. Added a regression test for the exact-multiple boundary case.PR quality check