Skip to content

Escape delimiters in PDF names - #32483

Open
Priyank-gouda678 wants to merge 1 commit into
matplotlib:mainfrom
Priyank-gouda678:pdf-name-escape-delimiters
Open

Priyank-gouda678 wants to merge 1 commit into
matplotlib:mainfrom
Priyank-gouda678:pdf-name-escape-delimiters

Conversation

@Priyank-gouda678

@Priyank-gouda678 Priyank-gouda678 commented Oct 16, 2026 •

Copy link
Copy Markdown

PR summary

AI Disclosure

Yes. An AI coding assistant was used to find this while reading backend_pdf.Name, to write the patch and the regression test, and to build and run a reproducer (a TrueType font whose post-table glyph name contains PDF delimiters, saved with the default pdf.fonttype 3). I've reviewed the change and I'm responsible for it.

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • New and changed code is tested
  • [N/A] Plotting related features are demonstrated in an example
  • [N/A] New features and API changes have release notes
  • [N/A] Documentation complies with general and docstring guidelines

@github-actions

Copy link
Copy Markdown

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on discourse chat for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@iccir

iccir commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Hello! Please fill out the "PR Summary" and "AI Disclosure" sections of the original pull request template. Thank you!

@Priyank-gouda678

Copy link
Copy Markdown
Author

Added the AI disclosure section. The summary has to be in my own words per the template, so I'll write that one up myself shortly.

@iccir

iccir commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

I'm marking this PR as Autoclose. My impression is that the code is fully AI-generated and violates our policy on AI. If this is not the case, please let me or another maintainer know.

@iccir iccir added the status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks label Oct 19, 2026
@github-actions

Copy link
Copy Markdown

⏰ This pull request might be automatically closed in two weeks from now.

Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable.

Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬

To increase the chance of a productive review:

As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code.

If you substantially improve this PR within two weeks, leave a comment and a team member may remove the status: autoclose candidate label and the PR stays open. Cosmetic changes or incomplete fixes will not be sufficient. Maintainers will assess improvements on their own schedule. Please do not ping (@) maintainers.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend: pdf first-contribution status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants