Repository navigation
Conversation
np.log10(0) produces -inf, and np.floor(-inf) is fine. But on riscv64 the intermediate NaN from the full expression evaluation triggers "RuntimeWarning: invalid value encountered in floor". The existing errstate only suppresses "divide" warnings but not "invalid". This causes TestAsinhLocator tests and test_minorticks_toggle to fail on riscv64.
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
|
Thanks for working on this! |
cfaed8c to
e025e7f
Compare
The default 60-second timeout in subprocess_run_for_testing is too short for riscv64, causing test_sphinxext and test_determinism_check to fail with TimeoutExpired. Increase the default by 6 for CI environments.
|
Changed approach a bit. There were two tests which timed out so both now use 'is CI' multiplier. |
| timeout = 60 | ||
| if is_ci_environment(): | ||
| timeout *= 6 |
There was a problem hiding this comment.
This can be condensed.
| timeout = 60 | |
| if is_ci_environment(): | |
| timeout *= 6 | |
| timeout = 360 if is_ci_environment() else 60 |
There was a problem hiding this comment.
It can. But it is done that way in other files so I kept the style.
Also it is not Perl to make everything one line.
| timeout = 60 | ||
| if is_ci_environment(): | ||
| timeout *= 6 |
There was a problem hiding this comment.
| timeout = 60 | |
| if is_ci_environment(): | |
| timeout *= 6 | |
| timeout = 360 if is_ci_environment() else 60 |
PR summary
The current hardware for RISC-V architecture is quite slow. Matplotlib tests can be run with "CI=1" which multiplies timeouts by six but there are tests not covered by it. One of changes bumps such place from 60 to 300 seconds.
The other problem is NaN related as RISC-V has other approach to those.
AI Disclosure
LLM was used to analyse build log.
PR quality check