Repository navigation
Fix text wrapping when y position is 1.0 - #32394
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Add special cases for rotation angles 0, 90, 180, and 270 degrees to avoid division by zero and incorrect distance calculations at the edges of the figure box. Fixes matplotlib#31537.
Member
|
This account is opening a lot of PRs in a short space of time so I assume they are automated. Closing the PR and blocking the account for a week per our policy |
Member
|
Also this issue already has a fix at #31546 and I do not recall why that stalled. |
Member
|
Actually, we already blocked this account for a week for the same reason here #32279 (comment). Behaviour has not changed so now blocking indefinitely. |
rcomer
added
the
ai-contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where text wrapping doesn't work correctly when the vertical position is set to exactly 1.0 (top of the figure). The fix adds special cases for rotation angles 0, 90, 180, and 270 degrees to avoid division by zero and incorrect distance calculations at the edges of the figure box.
Fixes #31537.