Raise a clear error on incomplete Type1 font sections - #32193
Open
vsaraikin wants to merge 3 commits into
Open
Conversation
Member
|
It seems reasonable to catch all of these, but would it be simpler to catch it at the call site instead of indenting everything? |
Contributor
Author
|
Much better, thanks. The dispatch already knows the key so the message builds itself. It also covers all four parsers instead of three. I dropped the try from |
QuLogic
reviewed
Aug 11, 2026
Contributor
Author
|
Split, thanks. Only the call is inside the |
QuLogic
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32062.
A truncated Type1 font raises a bare
StopIterationout of the parser:Nothing about the file, no message at all. #32062 fixed that for
/Subrs, since the review there asked for it. The three sibling parsers were left as they were, so/CharStrings,/Encodingand/OtherSubrsstill do it on 3.11.1.They now raise the same kind of error, for example
RuntimeError("Malformed Type1 font file: Incomplete /CharStrings").Most of the diff is the reindent from the
tryblock. It reads much better with whitespace ignored, where it is 26 lines added and 5 removed.Five parametrised cases cover the truncation points. All five fail on main