Skip to content

TYP: Improve type coverage in _triplot and _triangulation - #32140

Open
Aniketsy wants to merge 1 commit into
matplotlib:mainfrom
Aniketsy:type-triangulation
Open

TYP: Improve type coverage in _triplot and _triangulation#32140
Aniketsy wants to merge 1 commit into
matplotlib:mainfrom
Aniketsy:type-triangulation

Conversation

@Aniketsy

@Aniketsy Aniketsy commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

PR summary

with this we cover 100 % type coverage in tri._triplot and tri._triangulation

Towards #32157

AI Disclosure

No ai

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • New and changed code is tested
  • Plotting related features are demonstrated in an example
  • New features and API changes have release notes
  • Documentation complies with general and docstring guidelines

@Aniketsy Aniketsy changed the title TYP: Annotate *args/**kwargs in _triplot and _triangulation TYP: Improve type coverage in _triplot and _triangulation Jul 30, 2026
@Aniketsy

Aniketsy commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Ahh sorry, i got a doubt and will stop here , what i thought maybe there will be missing type hints, but i got only one till now and other were for **kwarg. So this does not make sense to open a PR for every file.

i'd like to know thoughts on this, if we should not annotate **kwarg as Any or we can cover all the cases in single PR

got answer from other PR review, look for the supported kwargs and we can define more specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants