DOC : clarify event_loop_is_running docstring - #32119
Open
joddeepesh-cloud wants to merge 1 commit into
Open
Conversation
iccir
reviewed
Jul 25, 2026
iccir
reviewed
Jul 25, 2026
iccir
reviewed
Jul 25, 2026
joddeepesh-cloud
force-pushed
the
issue-32041-macos-event-loop
branch
from
July 27, 2026 17:24
938933d to
7fe88ec
Compare
joddeepesh-cloud
force-pushed
the
issue-32041-macos-event-loop
branch
from
July 27, 2026 17:59
f828e54 to
248a084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the docstring for
event_loop_is_running()in the macOS backend.The previous docstring described what the function returns, but did not clarify that its name is intentionally imprecise. This update explains that the function reports whether the macOS backend has initialized the NSApp main event loop, rather than determining whether an arbitrary event loop is running.
Closes #32041