Skip to content

DOC: add 2 review policy for large doc PRs #32113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksunden merged 1 commit into from
Aug 7, 2026
+3 −2
Merged

DOC: add 2 review policy for large doc PRs #32113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/devel/pr_guide.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,9 @@ fundamental and can easily be reverted at any time in the future.

Some explicit rules following from this:

* *Documentation and examples* may be merged with a single approval. Use
the threshold "is this better than it was?" as the review criteria.
* Small and medium sized *Documentation and examples* may be merged with a single approval.
Use the threshold "is this better than it was?" as the review criteria. Large documentation
PRs (e.g. adds large new sections or new rst pages) require two reviews.

* Minor *infrastructure updates*, e.g. temporary pinning of broken dependencies
or small changes to the CI configuration, may be merged with a single
Expand Down
Loading