Add mutexes around usage of FT_Library - #32096
Open
clin1234 wants to merge 2 commits into
Open
Conversation
clin1234
force-pushed
the
critical_sections
branch
from
July 22, 2026 19:03
17e3de0 to
6674323
Compare
Member
These are unrelated things, and belong in separate PRs. |
clin1234
changed the title
clin1234
changed the title
clin1234
marked this pull request as ready for review
July 22, 2026 22:42
Author
|
@QuLogic Ping |
clin1234
force-pushed
the
critical_sections
branch
2 times, most recently
from
August 23, 2026 09:56
0804b2b to
1b042a8
Compare
clin1234
force-pushed
the
critical_sections
branch
from
August 23, 2026 10:27
29d4726 to
1b042a8
Compare
clin1234
force-pushed
the
critical_sections
branch
from
August 23, 2026 11:14
1b042a8 to
c6e919f
Compare
…r boundary - RendererAgg: hold pixBuffer, alphaBuffer and hatchBuffer in std::unique_ptr<agg::int8u[]> so they cannot leak, and drop the now-empty manual destructor - FT2Image: allocate via calloc(width, height) so the size multiplication is overflow-checked, and throw std::bad_alloc on failure - PyFT2Font_init: build the object in a unique_ptr and release() only on success, so a font that fails to open does not leak - mpl_GetCurrentProcessExplicitAppUserModelID: free the COM-allocated string even if py::cast throws - QhullInfo: delete the copy constructor and copy assignment, since it uniquely owns qh and error_file - PyFT2Font: add a recursive_mutex taken only at the wrapper boundary, so concurrent calls on the same font under free-threading cannot corrupt its glyph slot, glyph list or image buffer Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
clin1234
force-pushed
the
critical_sections
branch
from
August 23, 2026 11:22
c6e919f to
58357dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve (mostly) #31424 and #32065