TYP: Use new generic type syntax from PEP 695#31923
Merged
Merged
Conversation
QuLogic
force-pushed
the
generic-types
branch
2 times, most recently
from
2db04ea to
8730d9f
Compare
We can do this now that we require Python 3.12.
No longer do we need to define private `TypeVar` variables with semi-unique names, but instead a function/class/method-local type can be created. As these are now local, I have dropped the leading underscores.
timhoffm
approved these changes
Jun 25, 2026
| def cla(self) -> None: ... | ||
|
|
||
| class ArtistList(Sequence[_T]): | ||
| class ArtistList[T: Artist](Sequence[T]): |
Member
There was a problem hiding this comment.
Is parametrization necessary here? I think we can direktly replace T -> Artist.
Member
Author
There was a problem hiding this comment.
Yes, each of the sublists (.collections, .lines, etc.) is specialized with a specific Artist subclass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This is now available with our minimum Python 3.12, and allows doing away with
TypeVar,TypeAlias, andParamSpec.Note, this is based on #31920.
AI Disclosure
PR checklist