Skip to content

Convert macOS backend to ARC #31855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iccir wants to merge 3 commits into
base: main
Choose a base branch
from
+150 −217
Open

Convert macOS backend to ARC #31855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e11758b
Convert macOS backend to ARC
iccir Jun 7, 2026
8fd5e75
Assume minimum version of macOS 10.14
iccir Jun 8, 2026
605ced1
Rework window closing
iccir Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cibuildwheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:
CIBW_SKIP: "*-musllinux_aarch64"
CIBW_TEST_COMMAND: >-
python {package}/ci/check_version_number.py
MACOSX_DEPLOYMENT_TARGET: "10.12"
MACOSX_DEPLOYMENT_TARGET: "10.14"
strategy:
matrix:
include:
Expand Down
7 changes: 5 additions & 2 deletions lib/matplotlib/backends/backend_macosx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from .backend_agg import FigureCanvasAgg
from matplotlib.backend_bases import (
_Backend, FigureCanvasBase, FigureManagerBase, NavigationToolbar2,
ResizeEvent, TimerBase, _allow_interrupt)
CloseEvent, ResizeEvent, TimerBase, _allow_interrupt)


class TimerMac(_macosx.Timer, TimerBase):
Expand Down Expand Up @@ -161,7 +161,10 @@ def __init__(self, canvas, num):
self.show()
self.canvas.draw_idle()

def _close_button_pressed(self):
def _handle_window_will_close(self):
CloseEvent("close_event", self.canvas)._process()

def _handle_window_should_close(self):
Gcf.destroy(self)
self.canvas.flush_events()

Expand Down
Loading
Loading