Skip to content

DOC: correct some outdated points in Artist tutorial#31696

Merged
timhoffm merged 2 commits into
matplotlib:mainfrom
rcomer:artist-tutorial
May 17, 2026
Merged

DOC: correct some outdated points in Artist tutorial#31696
timhoffm merged 2 commits into
matplotlib:mainfrom
rcomer:artist-tutorial

Conversation

@rcomer

@rcomer rcomer commented May 17, 2026

Copy link
Copy Markdown
Member

PR summary

  • "As we will discuss below..." does not lead to any discussion of this below. I thought about instead linking to the embedding examples, but these days you don't have to be doing your own clever things with canvases to not use pyplot. We could change a lot of this tutorial to instantiate the figures directly, but there are two examples that use sphinx-gallery to show a plot, and I think they do need pyplot.
  • I think the hold state reference relates to some functionality that was deprecated in v2.
  • Updated the print output to what I currently see.

AI Disclosure

None

PR checklist

@github-actions github-actions Bot added the Documentation: tutorials files in galleries/tutorials label May 17, 2026
@rcomer

rcomer commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

This tutorial also states

Each of the properties is accessed with an old-fashioned setter or getter (yes we know this irritates Pythonistas and we plan to support direct access via properties or traits but it hasn't been done yet).

Do we still have an aspiration to make properties for the properties? I don't even know what traits are.

timhoffm
timhoffm approved these changes May 17, 2026
View reviewed changes

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus possibly the suggested change, buy you can decide.

Overall, there's a lot more that can and should be changed in the tutorial, but I don't want to go down this rabbit hole right now.

Comment thread galleries/tutorials/artists.py Outdated
@rcomer @timhoffm
Apply suggestion from @timhoffm
d96a905 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@timhoffm timhoffm added this to the v3.11.0 milestone May 17, 2026
@timhoffm timhoffm merged commit 67cbe92 into matplotlib:main May 17, 2026
21 checks passed
@meeseeksmachine meeseeksmachine mentioned this pull request May 17, 2026
Merged
@rcomer rcomer deleted the artist-tutorial branch May 17, 2026 21:38
timhoffm added a commit that referenced this pull request May 17, 2026
@timhoffm @meeseeksmachine
Backport PR #31696: DOC: correct some outdated points in Artist tutorial
bbffaa2
timhoffm added a commit that referenced this pull request May 17, 2026
@timhoffm
Merge pull request #31698 from meeseeksmachine/auto-backport-of-pr-31…
9e2c940 
…696-on-v3.11.x

Backport PR #31696 on branch v3.11.x (DOC: correct some outdated points in Artist tutorial)
@story645

story645 commented May 17, 2026

Copy link
Copy Markdown
Member

I don't even know what traits are.

https://docs.enthought.com/traits/traits_user_manual/intro.html

Far as I can tell, it's a mashup of type theory and properties that we'd probably now achieve through custom types and the like. (There was a failed GSoC for it years ago).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Documentation: tutorials files in galleries/tutorials

Projects

None yet

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rcomer @story645 @timhoffm