Repository navigation
TST: Harden handling of Popen subprocesses - #31503
Merged
Merged
Conversation
We do attempt to kill the subprocess in all cases, but this should also ensure that file descriptors are closed.
If the port's in use, then we want to allow retries and connect to whichever port it ends up on.
Just to be on the safe side that it closes.
ksunden
reviewed
Apr 16, 2026
Co-authored-by: Kyle Sunden <git@ksunden.space>
ksunden
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR does two things:
_WaitForStringPopenin a context manager: We do attempt to kill the subprocess in all cases, but this should also ensure that file descriptors are closed.test_webaggI don't know that this would fix CI, but I'm hoping that at least the context manager will prevent the unraisable warning that leaks into other tests.
AI Disclosure
None
PR checklist