-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
DOC: Remove pyplot vs. OO interface discussion from lifecycle example #31423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link to the quick start guide here as a way to guide users back to the rest of the docs?
https://matplotlib.org/stable/users/explain/quick_start.html
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes this example special that warrants referencing the quick start guide?
The pyplot vs. OO was just here because the blog post from which the example was created was a general
https://pbpython.com/effective-matplotlib.html. But in the context of our own docs, we don't need to reference everything back to quick start. Instead, we assume that a user has the basic understanding from quickstart already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's written as a self-contained doc, so maintaining a bit of context via links seems useful. Crosslinking never hurts and we could do more of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm of a different opinion here. Examples and tutorials in our docs can and should never be self-contained. You cannot jump into an arbitrary place of the docs and expect to understand it without prior knowledge.
Cross-linking hurts if the topic is not directly relevant to the content at hand because it dillutes focus and creates clutter.
Since we obviously have different opinions, I recuse myself from the topic, as such discusions typically lead nowhere. I leave it up to you guys to fix the lifecycle tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure fair enough, but I apologize if it seemed I was demanding this - it was just a suggestion, and you asked why I was making it, so I answered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a part of a larger discussion on modality and purpose. I also agree w/ @jklymak that a cross-reference is nice to have (here mostly to keep the spirit of the original) but I think removing this is a plus 'cause seperatly I think it's a bad idea to explain things twice cause that introduces the potential for drift.