Skip to content

DOC: modernize lifecycle tutorial with annotate and bar_label #31364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manasvi-sahare wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −8
Open

DOC: modernize lifecycle tutorial with annotate and bar_label #31364

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a12924d
DOC: modernize lifecycle tutorial with annotate and bar_label
m-sahare Mar 24, 2026
7170a3a
DOC: fix docs build by removing invalid image reference
m-sahare Mar 24, 2026
893076f
Merge remote-tracking branch 'upstream/main' into doc-lifecycle-moder…
m-sahare Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions galleries/tutorials/lifecycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,8 @@
<https://pbpython.com/effective-matplotlib.html>`_
by Chris Moffitt. It was transformed into this tutorial by Chris Holdgraf.

A note on the explicit vs. implicit interfaces
==============================================

Matplotlib has two interfaces. For an explanation of the trade-offs between the
explicit and implicit interfaces see :ref:`api_interfaces`.
For a detailed explanation of the explicit (object-oriented) vs implicit
(pyplot) interfaces, see :ref:`api_interfaces`.

In the explicit object-oriented (OO) interface we directly utilize instances of
:class:`axes.Axes` to build up the visualization in an instance of
Expand All @@ -47,6 +44,7 @@

In general, use the explicit interface over the implicit pyplot interface
for plotting.

Check warning on line 47 in galleries/tutorials/lifecycle.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Blank line contains whitespace

Raw Output:
message:"Blank line contains whitespace"  location:{path:"/home/runner/work/matplotlib/matplotlib/galleries/tutorials/lifecycle.py"  range:{start:{line:47  column:1}  end:{line:47  column:3}}}  severity:WARNING  source:{name:"ruff"  url:"https://docs.astral.sh/ruff"}  code:{value:"W293"  url:"https://docs.astral.sh/ruff/rules/blank-line-with-whitespace"}  suggestions:{range:{start:{line:47  column:1}  end:{line:47  column:3}}}

Our data
========
Expand Down Expand Up @@ -117,7 +115,8 @@
# Now let's remake the above plot to see how it looks:

fig, ax = plt.subplots()
ax.barh(group_names, group_data)
bars = ax.barh(group_names, group_data)
ax.bar_label(bars, padding=3)
Copy link
Copy Markdown
Member

@jklymak jklymak Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think labelling the bar is of particular use here.

There are a subsequent 6 other plots with this same barplot, so why only label the second one?

I'm not in favour of this change.


# %%
# The style controls many things, such as color, linewidths, backgrounds,
Expand Down Expand Up @@ -242,8 +241,12 @@

# Annotate new companies
for group in [3, 5, 8]:
ax.text(145000, group, "New Company", fontsize=10,
verticalalignment="center")
ax.annotate("New Company",
Copy link
Copy Markdown
Member

@jklymak jklymak Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, I don't think this is an improvement.

xy=(group_data[group], group),
xytext=(145000, group),
textcoords="data",
fontsize=10,
va="center")

# Now we move our title up since it's getting a little cramped
ax.title.set(y=1.05)
Expand Down
Loading