-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Emit xlim_changed / ylim_changed when limits expand via set_xticks / set_yticks #31251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+24
−0
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fdf900b
Emit xlim/ylim_changed when limits expand via set_xticks/set_yticks
Chirag3841 8471a33
error fix
Chirag3841 3d6e925
changes done
Chirag3841 84ab3ae
polar error fix
Chirag3841 0538e09
changes fixed
Chirag3841 7f9ca1f
set axis name to avoid polar issue
Chirag3841 1fb7012
initial commit
Chirag3841 487cf88
stopping reapplying limits
Chirag3841 6cbc63f
error fixing
Chirag3841 9b26724
back to basic
Chirag3841 ef0d397
set auto as none
Chirag3841 7d95efc
pushing previous implementation
Chirag3841 b450214
rerun CI
Chirag3841 d8708bc
remove none fallback
Chirag3841 98200de
use get_view_interval()
Chirag3841 e1d5e64
add guard
Chirag3841 2639ad2
push commit
Chirag3841 5ee7858
callback
Chirag3841 b4fd8e3
callback corrected
Chirag3841 9f81b24
test file update
Chirag3841 062e142
test file updated
Chirag3841 9afb0ff
re run ci
Chirag3841 9a38457
tuple added
Chirag3841 69962d4
revert changes
Chirag3841 7d37a83
trigger ci
Chirag3841 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure: Have you checked that this is the right place to call the callbacks? Could it be on a broader (caller of _set_tick_locations) or narrower (set_view_interval) scope?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the callback in _set_tick_locations since this is where limits are updated due to tick changes.
Moving it to set_view_interval would trigger the callback for all view limit updates, which seems broader than intended here.