Skip to content

BUG: Fix IndexLocator.tick_values returning values greater than vmax #31091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 5 commits into from
Feb 6, 2026
+21 −2
Merged

BUG: Fix IndexLocator.tick_values returning values greater than vmax #31091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54e673c
BUG: Fix IndexLocator.tick_values returning values greater than vmax
saakshigupta2002 Feb 5, 2026
5adc3f7
Update lib/matplotlib/tests/test_ticker.py
saakshigupta2002 Feb 5, 2026
b11b32c
Update lib/matplotlib/ticker.py
saakshigupta2002 Feb 5, 2026
bd6f097
Update lib/matplotlib/tests/test_ticker.py
saakshigupta2002 Feb 5, 2026
f6cdf99
Simplify remaining test assertions per review feedback
saakshigupta2002 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/matplotlib/tests/test_ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,22 @@ def test_set_params(self):
assert index._base == 7
assert index.offset == 7

def test_tick_values_not_exceeding_vmax(self):
"""
Test that tick_values does not return values greater than vmax.
"""
# Test case where offset=0 could cause vmax to be included incorrectly
index = mticker.IndexLocator(base=1, offset=0)
assert_array_equal(index.tick_values(0, 4), [0, 1, 2, 3, 4])

# Test case with fractional offset
index = mticker.IndexLocator(base=1, offset=0.5)
assert_array_equal(index.tick_values(0, 4), [0.5, 1.5, 2.5, 3.5])

# Test case with base > 1
index = mticker.IndexLocator(base=2, offset=0)
assert_array_equal(index.tick_values(0, 5), [0, 2, 4])


class TestSymmetricalLogLocator:
def test_set_params(self):
Expand Down
7 changes: 5 additions & 2 deletions lib/matplotlib/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,8 +1767,11 @@ def __call__(self):
return self.tick_values(dmin, dmax)

def tick_values(self, vmin, vmax):
return self.raise_if_exceeds(
np.arange(vmin + self.offset, vmax + 1, self._base))
# We want tick values in the closed interval [vmin, vmax].
# Since np.arange(start, stop) returns values in the semi-open interval
# [start, stop), we add a minimal offset so that stop = vmax + eps
tick_values = np.arange(vmin + self.offset, vmax + 1e-12, self._base)
return self.raise_if_exceeds(tick_values)


class FixedLocator(Locator):
Expand Down
Loading