-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Merge main back into text-overhaul branch #31063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more consistency and similarity with RadioButtons
Bumps the actions group with 2 updates in the / directory: [github/codeql-action](https://github.com/github/codeql-action) and [actions/cache](https://github.com/actions/cache). Updates `github/codeql-action` from 4.31.9 to 4.31.10 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5d4e8d1...cdefb33) Updates `actions/cache` from 5.0.1 to 5.0.2 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@9255dc7...8b402f5) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: actions/cache dependency-version: 5.0.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com>
…ctions-a72d6170ce Bump the actions group across 1 directory with 2 updates
The concept of alias priority was deprecated in 71d725f and has been removed since then (making normalize_kwargs maintain kwarg order).
Remove outdated notion of property alias priority from docs.
…comment Fix grammar: 'it would better' -> 'it would be better' in comment
Explicitly state that the default levels corresponds to n=7 and clarifies that int input targets n+1 levels but may produce n+2.
Share all the trivial functions which are identical without any further modifications.
DOC: update and slightly reorg docs docs
widgets: use a shared _Buttons class for {Radio,Check}Buttons
This is generally frowned upon (though we don't actually change it, so it's safe), but more importantly, Sphinx tries to put all the values into the docstring, which just looks bad.
The new version appears to be causing some issues for our missing reference checks, so reverting back to the old implementation should buy us some time to fix things.
…tyle-file Fix formatting: add space after # in TODO comment
DOC: move doc build options into tables and tabs
DOC: Fix doc builds with Sphinx 9
* FIX: Handle AxesWidget cleanup after failed init * Apply code review suggestions * Update lib/matplotlib/tests/test_widgets.py Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> * Remove __del__ method * Remove AxesWidget.__del__ from widgets.pyi --------- Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
If Pillow is old enough to not support a feature _at all_, then it will warn about it. If you're running the whole test suite, then something else seems to cause pytest to treat it as benign. But if you run only `test_agg.py`, then our `-Werror` setting will cause it to fail test collection.
TST: Fix warnings from Pillow for unavailable features
Directly store property alias information in `{"alias": "propety", ...}`
format, which greatly speeds up normalize_kwargs.
In order to not worry about two different dict formats (the new one, and
the old one, which was `{"property": ["alias", ...], ...}`) in
normalize_kwargs, deprecate support for directly passing an alias map --
callers should always pass an artist (or artist type) directly, which
hides the detail of the format of the alias map. Also deprecate passing
`alias_mapping=None`, which doesn't really seem needed (unlike
`kw=None`, which is regularly used).
Whether the format of aliases passed to `_api.define_aliases` should
also be changed to match the new format is a separate question that
doesn't have to be addressed here (it can be changed later, being fully
private anyways).
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Doc: Clarify default levels behavior in contour/contourf
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
…31041) * Add test for invalid property names passed to setp * Fix blank line spacing for ruff * Add tests for error handling in Artist.set * Fix trailing whitespace in test_artist --------- Co-authored-by: Aditya Singh <adityasinghparmar60@gmail.com>
DOC: Clarify Artist.set() behavior
Using the extension from #28930, drop the static generated rcParams file, and move to a directive that gets generated on build. This avoids the table getting out of date as rcParams are changed. Note, that this also hides the private (`_`-prefixed) rcParams.
The attribute `eventson` was introduced in 79aa291. While it was set on and off in various places, there has never been any code that made logic depend on its state. The attribute itself was removed in #18910, but its toggling through the context manager was overlooked there. Note: There is another `eventson` in widgets.py, which is completely independent on this here, because widgets are not Artists.
--------- Co-authored-by: Scott Shambaugh <scottshambaugh@users.noreply.github.com> Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
PERF: Refactor bezier poly coefficient calcs for speedup
MNT: Remove unused eventson context from artist property update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: Run cygwin
Run cygwin tests on a PR
Documentation: build
building the docs
Documentation: devdocs
files in doc/devel
Documentation: examples
files in galleries/examples
Documentation: user guide
files in galleries/users_explain or doc/users
GUI: tk
Maintenance
topic: contour
topic: pyplot API
topic: rcparams
topic: styles
topic: text
topic: toolbar
topic: widgets/UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This should fix the doc builds now with #31028 in.
PR checklist