BUG: Fix text appearing far outside valid axis scale range#31061
Open
scottshambaugh wants to merge 2 commits intomatplotlib:mainfrom
Open
BUG: Fix text appearing far outside valid axis scale range#31061scottshambaugh wants to merge 2 commits intomatplotlib:mainfrom
scottshambaugh wants to merge 2 commits intomatplotlib:mainfrom
Conversation
scottshambaugh
changed the title
scottshambaugh
force-pushed
the
log_text_negative_coord
branch
from
0d3ef72 to
7ef9295
Compare
scottshambaugh
force-pushed
the
log_text_negative_coord
branch
from
7ef9295 to
4ffb8d3
Compare
scottshambaugh
commented
Feb 3, 2026
| return bbox | ||
|
|
||
| def get_tightbbox(self, renderer=None): | ||
| # Exclude text at data coordinates outside the valid domain of the axes |
Contributor
Author
There was a problem hiding this comment.
if not self.get_visible() or self.get_text() == "":
return Bbox.null()I had originally included these lines, but they were changing a half dozen baseline images as plots expanded to fill space where there was empty/invisible text. Removed for now, but I think that's probably the right behavior and we can discuss including it.
Member
There was a problem hiding this comment.
If you think that might be important, you can target that change to the text-overhaul branch.
Contributor
Author
There was a problem hiding this comment.
Do you mean this PR or just that change?
Member
There was a problem hiding this comment.
The additional change, unless it's easier for you to do the whole PR.
Contributor
Author
There was a problem hiding this comment.
Sure, I'll wait for this one to merge to avoid the def get_tightbbox conflict
timhoffm
reviewed
Feb 3, 2026
scottshambaugh
force-pushed
the
log_text_negative_coord
branch
from
b558152 to
496411d
Compare
scottshambaugh
force-pushed
the
log_text_negative_coord
branch
from
496411d to
20103e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #31054
Textdidn't have aget_tightbboxoverride yet, so this adds that with some handling for no-show cases. The_in_axes_domaincheck is not exclusive to text and may be useful elsewhere, so was given toArtistmore broadly.The plot in the original issue renders correctly now, and I can confirm it was broken for me before:
PR checklist