Hi @story645 , Can you please review.

Is their context for this change? Like a discussion in a PR or something? I'm unclear what problem it's fixing given there wasn't a coverage failure.

There wasn’t any recent coverage failure behind this change. The goal is just to make the current behavior explicit, setp already raises an AttributeError when an invalid property name is passed, but there wasn’t a test that directly checked this.

setp itself does not do any checking on the parameter name, but just passes it straight to the artists' set method. So I think if we're going to add this, it should be a test on set not setp.

If we completely remove the specific error within _update_props, then it will just try to call

In [4]: line.set_not_a_property(1)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[4], line 1
----> 1 line.set_not_a_property(1)

AttributeError: 'Line2D' object has no attribute 'set_not_a_property'

So we still get an AttributeError and the test still passes. But the error message is not what we want, so the test should also check the message.

As discussed in #30979, the set method is generally lacking in tests. Since that PR is unlikely to progress quickly, you are welcome to pull the new test out of there and add some for exceptions, including the one about not accepting duplicate aliases.

Thank you for the clarification. I’ll rework the tests accordingly and push an update.

Thanks @aditya-singh597. I'm going to mark this as "draft" for now. Please mark it as "ready for review" when you are ready. In the meantime, if you need help, feel free to ask questions here. Or you may prefer to ask them in our incubator chat.

Sure. I'll mark it ready for review when I'm done.

Thanks @aditya-singh597 and congratulations on your first Matplotlib PR 🎉 Hopefully we will hear from you again.

@rcomer
Thank you for the guidance, it was very helpful.