TST: account for flakiness with Numpy v1 #30950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The flaky tests on display in the CI are unrelated 🙃 |
timhoffm
approved these changes
Jan 11, 2026
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
QuLogic
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #30882
As noted at #30882 (comment), the flakiness in the minver tests goes away with Numpy v2.0. Most of these tests will pass against Numpy v1.x if we add a small tolerance. The
pcolortest is sensitive to the exact value ofx[1](#30882 (comment)).I have run minver with this change 48 times on my fork, and all runs passed. I think previously the fails were in around 10% of runs, so this result is statistically significant at the 1% level. (Split between two pushes as I accidentally left a MacOS run in the first lot).
PR checklist