Skip to content

TST: always force the SETUPTOOLS_SCM version in test subprocesses #30947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 2 commits into from
Jan 12, 2026
Merged

TST: always force the SETUPTOOLS_SCM version in test subprocesses #30947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7535599
TST: always force the SETUPTOOLS_SCM version in test subprocesses
tacaswell Jan 9, 2026
0b0f888
DOC: fix comment
tacaswell Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions lib/matplotlib/testing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,26 @@ def subprocess_run_helper(func, *args, timeout, extra_env=None):
f"_module = importlib.util.module_from_spec(_spec);"
f"_spec.loader.exec_module(_module);"
f"_module.{target}()",
*args
*args,
],
env={**os.environ, "SOURCE_DATE_EPOCH": "0", **(extra_env or {})},
timeout=timeout, check=True,
env={
**os.environ,
"SOURCE_DATE_EPOCH": "0",
# subprocess_run_helper sets SOURCE_DATE_EPOCH=0 above, so for a dirty tree,
# the version will have the date 19700101 which breaks pickle tests with a
# warning if the working tree is dirty.
#
# This will also avoid at least one additional subprocess call for
# setuptools-scm query git, so we tell the subprocess what version
# to report as the test process.
"SETUPTOOLS_SCM_PRETEND_VERSION_FOR_MATPLOTLIB": mpl.__version__,
**(extra_env or {}),
},
timeout=timeout,
check=True,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
text=True
text=True,
)
return proc

Expand Down
10 changes: 1 addition & 9 deletions lib/matplotlib/tests/test_pickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,15 +150,7 @@ def test_pickle_load_from_subprocess(fig_test, fig_ref, tmp_path):
proc = subprocess_run_helper(
_pickle_load_subprocess,
timeout=60,
extra_env={
"PICKLE_FILE_PATH": str(fp),
"MPLBACKEND": "Agg",
# subprocess_run_helper will set SOURCE_DATE_EPOCH=0, so for a dirty tree,
# the version will have the date 19700101. As we aren't trying to test the
# version compatibility warning, force setuptools-scm to use the same
# version as us.
"SETUPTOOLS_SCM_PRETEND_VERSION_FOR_MATPLOTLIB": mpl.__version__,
},
extra_env={"PICKLE_FILE_PATH": str(fp), "MPLBACKEND": "Agg"},
)

loaded_fig = pickle.loads(ast.literal_eval(proc.stdout))
Expand Down
Loading