FIX: Increase reruns for flaky test_invisible_Line_rendering (#30809)#30920
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Jan 3, 2026
Merged
FIX: Increase reruns for flaky test_invisible_Line_rendering (#30809)#30920QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
timhoffm
approved these changes
Jan 2, 2026
Member
timhoffm
left a comment
There was a problem hiding this comment.
This only helps in some edge cases, but does not cost us anything, so ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR addresses the flaky test
test_invisible_Line_rendering(#30809) by increasing the number of reruns in the@pytest.mark.flakydecorator from 3 → 5.Why is this change necessary?
The test is timing-based and occasionally fails on loaded systems due to natural timing variability. Increasing reruns reduces intermittent failures while keeping the test fast.
What problem does it solve?
Reduces false negatives in CI caused by timing noise. No functional code is changed.
What is the reasoning for this implementation?
Maintainers recommended increasing reruns as the simplest and safest approach to address flaky timing tests. Other approaches (increasing thresholds or repeats) would either reduce sensitivity or slow down the test unnecessarily.
PR checklist
pytestpasses)