Call Refresh on FigureCanvasWxAgg.draw #30893
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in which some widgets are not redrawn under wayland.
Contributor
|
@hydrocat Thanks for looking into this. Also: should this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in which some plots are not redrawn under wayland.
PR summary
Why is this change necessary?
What problem does it solve?
Under wayland and wxwidgets, the canvas was only being redraw after user interaction. Programmatic updates from code, such as a background task, would somehow, not trigger a plot redraw.
What is the reasoning for this implementation?
Sorry, not much reasoning. I followed the code path and sprinkled what I thought could work. The best I can think of is that wxwidgets is not being notified of the need to repaint the canvas.
I tried to find a way to force redraw of the plot canvas in wxWidgets backend. This place seems to fix it.
Running a demo script with
GDK_BACKEND=x11 python demo.pyfixes it too, but then it is not using wayland.PR checklist