Skip to content

BUG: Fix Windows subprocess timeouts with CREATE_NO_WINDOW flag #30886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanchit122006 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BUG: Fix Windows subprocess timeouts with CREATE_NO_WINDOW flag #30886

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
662ae78
Added CREATE_NO_WINDOW flag on Windows to prevent console window over…
sanchit122006 Dec 20, 2025
bb3f68a
Fixed Ruff Failed check error
sanchit122006 Dec 20, 2025
a46095e
Fixed Ruff error
sanchit122006 Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/matplotlib/testing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ def subprocess_run_for_testing(command, env=None, timeout=60, stdout=None,
"""
if capture_output:
stdout = stderr = subprocess.PIPE
# Add CREATE_NO_WINDOW flag on Windows to prevent console window overhead
# This significantly reduces subprocess creation time and helps avoid timeouts
if sys.platform == 'win32':
if 'creationflags' not in kwargs:
kwargs['creationflags'] = subprocess.CREATE_NO_WINDOW
else:
kwargs['creationflags'] |= subprocess.CREATE_NO_WINDOW
try:
proc = subprocess.run(
command, env=env,
Expand Down
Loading