Fix macOS toolbar crash #30863
Merged
Fix macOS toolbar crash #30863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Dec 15, 2025
Member
tacaswell
left a comment
tacaswell
left a comment
There was a problem hiding this comment.
Makes sense and I manually tested.
greglucas
approved these changes
Dec 15, 2025
Contributor
|
Thanks @lilfer! If you're in macos backend bug squashing mode, there are several other similar reference counting issues hanging around I think if you have any ideas for those too: https://github.com/matplotlib/matplotlib/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22GUI%3A%20MacOSX%22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #28513
Fixes a segmentation fault in the _macosx backend that occurs when closing figures.
In the original implementation of
NavigationToolbar2, it relied on the window to hold the only strong reference tomessagebox. The toolbar sometimes living longer than the window—and thusmessagebox— resulted in the crash.I'm still not sure why this crash seems to only occur when closing a figure that was created in the event loop.
Fix:
NavigationToolbar2now also retainsmessagebox.I checked that
messageboxis deallocated after a figure is closed andgc.collect()runs.PR checklist