Minor doc fixes re: close()ing figures. #30853
Merged
+16
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: pyplot API
Documentation: examples
timhoffm
reviewed
Dec 13, 2025
|
|
||
| # Option 2: Retrieve a memoryview on the renderer buffer, and convert it to a | ||
| # numpy array. | ||
| # Option 2: Manually attach a canvas to the figure (pyplot or savefig would |
Member
There was a problem hiding this comment.
When is this better than the fig.savefig approach? It feels a bit too low-level. Is this for cases where you want the image as numpy array with as little overhead as possible?
Contributor
Author
There was a problem hiding this comment.
You get to skip the encoding to png and decoding. Admittedly I doubt that it's that costly at all, but I didn't want to change the whole structure of the example either (and I guess it's also useful to showcase these internals (which are more or less what savefig does anyways) if anyone is curious about what happens under the hood).
Member
There was a problem hiding this comment.
Then let's spell it like this
Suggested change
| # Option 2: Manually attach a canvas to the figure (pyplot or savefig would | |
| # Option 2: Low-level approach to directly save to a numpy array | |
| # Manually attach a canvas to the figure (pyplot or savefig would |
timhoffm
approved these changes
Dec 13, 2025
Most fixes are self-explanatory. The change to the flask command-line allows using the same instructions on all OSes. The one to the CanvasAgg example is there because it is no longer (since mpl3.1) necessary to explicitly attach the canvas in the savefig() case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most fixes are self-explanatory. The change to the flask command-line allows using the same instructions on all OSes. The one to the CanvasAgg example is there because it is no longer (since mpl3.1) necessary to explicitly attach the canvas in the savefig() case.
PR summary
PR checklist