Repository navigation
MNT: Prototype LineStyle object for Line2D (#30828) - #30832
Closed
DipayanDasgupta wants to merge 1 commit into
Closed
DipayanDasgupta wants to merge 1 commit into
DipayanDasgupta wants to merge 1 commit into
Conversation
DipayanDasgupta
force-pushed
the
mnt-style-prototype
branch
from
December 10, 2025 13:41
549a935 to
3e024cf
Compare
Member
|
This is premature. Let's first decide what exactly we want. c.f. #30828 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to #30828
Prototype: LineStyle Container
This is a Proof of Concept implementing the proposal in #30828.
It introduces a
LineStyledataclass inlines.pyand refactorsLine2Dto storelinewidthinside this style object instead of directly on the instance.This demonstrates that we can separate style data without changing the public API.