Use std::visit to exhaust std::variant possibilities. - #30773
Merged
Conversation
github-actions
Bot
added
topic: text
topic: mpl_toolkit
topic: rcparams
backend: agg
topic: path handling
backend: ps
backend: pdf
backend: svg
backend: cairo
topic: text/fonts
topic: text/mathtext
topic: styles
CI: Run cibuildwheel
github-actions
Bot
removed
topic: text
topic: mpl_toolkit
topic: rcparams
topic: path handling
backend: ps
backend: pdf
backend: svg
backend: cairo
topic: text/mathtext
topic: styles
CI: Run cibuildwheel
QuLogic
approved these changes
Jan 17, 2026
QuLogic
left a comment
QuLogic
left a comment
Member
There was a problem hiding this comment.
IIRC, the reason for the std::get_if with an else instead of a plain std::get was that some old macOS deployment target didn't have the implementation. Since cibuildwheel appears okay with this build, I think this should be okay for us and looks clearer, for the most part.
github-actions
Bot
added
topic: ticks axis labels
topic: color/color & colormaps
topic: images
topic: text/mathtext
topic: legend
topic: collections and mappables
topic: styles
topic: contour
topic: axes
Documentation: build
Member
|
Can you rebase again? All the deprecated code paths are gone now. |
Member
|
I rebased this to fix the conflicts and added a second change of |
Contributor
Author
|
Looks like you forgot to push your rebase? |
This makes it unnecessary to silence impossible "unhandled" cases.
Member
|
Well, I did, but I forgot that #30291 was merged and didn't rebase on top of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it unnecessary to silence impossible "unhandled" cases. See #30607 (comment).
PR summary
PR checklist