Repository navigation
MNT: Improve Grouper - #30754
Merged
Merged
MNT: Improve Grouper#30754
Conversation
timhoffm
force-pushed
the
mnt-grouper
branch
from
November 16, 2025 23:52
f8d039f to
703aab5
Compare
- add Grouper.get_siblings(..., include_self=...) parameter - `Axes._shared_axes` is a class variable. Therefore, we can make `get_shared_x/y_axes()` class methods. This is in preparations of matplotlib#30159 (comment).
timhoffm
force-pushed
the
mnt-grouper
branch
from
November 18, 2025 14:46
703aab5 to
368c7c6
Compare
scottshambaugh
approved these changes
Feb 6, 2026
scottshambaugh
left a comment
Contributor
There was a problem hiding this comment.
This change makes sense to me and is backwards compatible elsewhere with the include_self=True default.
anntzer
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouper.get_siblings(..., include_self=...)parameter - Previously self was always included and we had to manually remove it. It's semantically more clear if we can specify what we want in theget_siblings()call.Axes._shared_axesis a class variable. Therefore, we can makeget_shared_x/y_axes()class methods.This is in preparations of #30159 (comment).