Skip to content

MNT: Improve Grouper - #30754

Merged
anntzer merged 1 commit into
matplotlib:mainfrom
timhoffm:mnt-grouper
Mar 5, 2026
Merged

anntzer merged 1 commit into
matplotlib:mainfrom
timhoffm:mnt-grouper

Conversation

@timhoffm

@timhoffm timhoffm commented Nov 16, 2025 •

Copy link
Copy Markdown
Member
  • add Grouper.get_siblings(..., include_self=...) parameter - Previously self was always included and we had to manually remove it. It's semantically more clear if we can specify what we want in the get_siblings() call.
  • Axes._shared_axes is a class variable. Therefore, we can make get_shared_x/y_axes() class methods.

This is in preparations of #30159 (comment).

- add Grouper.get_siblings(..., include_self=...) parameter
- `Axes._shared_axes` is a class variable. Therefore, we can make `get_shared_x/y_axes()` class methods.

This is in preparations of matplotlib#30159 (comment).

@scottshambaugh scottshambaugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me and is backwards compatible elsewhere with the include_self=True default.

Comment thread lib/matplotlib/axes/_base.py Resolved
@anntzer
anntzer merged commit 0aa0739 into matplotlib:main Mar 5, 2026
7 of 9 checks passed
@timhoffm
timhoffm deleted the mnt-grouper branch March 5, 2026 21:02
@QuLogic QuLogic added this to the v3.11.0 milestone Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants