Repository navigation
Fix for bug #3029. - #3067
Merged
Merged
Fix for bug #3029.#3067
Conversation
The FreeType class does not override the ``get_extension`` method, by default this method will return None. https://github.com/matplotlib/matplotlib/blob/6cf6063c7a3037d52545b2b7268623d33da0ecdd/setupext.py#L387 When calling the ``_check_for_pkg_config`` method a new extension will be created that what won't contain the original flags added by the ``add_flags`` method. https://github.com/matplotlib/matplotlib/blob/6cf6063c7a3037d52545b2b7268623d33da0ecdd/setupext.py#L438
Member
|
@mdboom Do we have a setup.py expert? |
Member
|
I'm sorry I missed this the first time around. I don't see how this resolves the original issue, and it ends up creating a new extension at the toplevel of the Python namespace that is not a Python extension: @tacaswell: I'm going to make a new blocker issue for this. |
frol
referenced
this pull request
Jul 19, 2015
seems to be broken. Use that only for version determination. Warn if pkg-config is not present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FreeType class does not override the
get_extensionmethod, by default this method will return None.matplotlib/setupext.py
Line 387 in 6cf6063
When calling the
_check_for_pkg_configmethod a new extension will be created that what won't contain the original flags added by theadd_flagsmethod.matplotlib/setupext.py
Line 438 in 6cf6063