Implement warning for Text3D's rotation/rotation_mode parameters #30600
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Sep 25, 2025
QuLogic
changed the title
Contributor
|
Hi @melwyncarlo, are you still interested in working on this PR? It looks like only a one-line change is needed to get it in a good state. |
Member
|
I've just committed the change. We don't have to go through review cycles to fix an unused import. |
scottshambaugh
approved these changes
Dec 18, 2025
timhoffm
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Currently, the
rotationandrotation_modeparameters are ignored for theText3Dclass.This affects code that accesses the class directly, as well as via the
Axes3D.textfunction.There is no implementation for the true 3D rotation of text in the current codebase.
It only rotates the text about the axis going through the display screen (set via the
zdirparameter).Implementing it is a serious undertaking which can't be achieved in a short matter of time.
Nevertheless, the parameters for it do exist in the public API which confuses users when they don't work as intended.
Therefore, a warning would be beneficial to warn the user about those two parameters being ignored/unimplemented.
This issue provisionally closes #30563.