Skip to content

Conversation

@lucasgruwez
Copy link
Contributor

PR summary

Consistent dashed zoom boxes.

  • Ensure that the zoom rubber band is dashed in all backends (it was not in WebAgg).
  • Fix the Tk rubber band: the implicit black line colour was not working, so it was set explicitly instead.

PR checklist

@QuLogic
Copy link
Member

QuLogic commented Sep 19, 2025

Can you post a before/after screenshot?

@lucasgruwez
Copy link
Contributor Author

Apologies for the delay, here's some screenshots. Note that the original TkAgg draws a white rubber band for the zoom, which is barely visible on a white background, so I've highlighted where it crosses the data

38438

@tacaswell
Copy link
Member

Ah, I assume the problem here is that with a dark theme, the default color is light? I do see a dashed line on my machine with a light themed UI.

@tacaswell tacaswell force-pushed the bugfix/consistent-rubber-bands branch from 51cdc41 to 5591531 Compare October 13, 2025 17:23
@tacaswell
Copy link
Member

Both CI failures are fixed on main, I rebase just to be sure (having now force pushed, I think I could have also closed and reopneed ....).

@tacaswell tacaswell added this to the v3.10.8 milestone Oct 13, 2025
@QuLogic QuLogic force-pushed the bugfix/consistent-rubber-bands branch from 5591531 to 15b64c0 Compare October 31, 2025 20:45
@QuLogic
Copy link
Member

QuLogic commented Oct 31, 2025

I rebased and pushed a fix for the webagg backend. On main, we used to get a solid rubberband:
Screenshot From 2025-10-31 04-48-51
and on this PR previously, we would get a dashed one with the wrong size:
Screenshot From 2025-10-31 04-49-13
Now with the latest change, we get a dashed one with both black and white, drawn the same way as Qt:
Screenshot From 2025-10-31 05-05-03

lucasgruwez and others added 2 commits October 31, 2025 16:49
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic force-pushed the bugfix/consistent-rubber-bands branch from 15b64c0 to e4ef103 Compare October 31, 2025 20:50
@timhoffm timhoffm merged commit ac67307 into matplotlib:main Nov 2, 2025
34 of 38 checks passed
@lumberbot-app
Copy link

lumberbot-app bot commented Nov 2, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ac6730773bc0b860e8c715f772928453efd7c42f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #30560: Consistent zoom boxes'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-30560-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR #30560 on branch v3.10.x (Consistent zoom boxes)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants