Skip to content

Fix unable to find Freefont on Ubuntu 14.04 - #3032

Closed
maciejkula wants to merge 1 commit into
matplotlib:masterfrom
maciejkula:bug/cannot_find_freefont
Closed

maciejkula wants to merge 1 commit into
matplotlib:masterfrom
maciejkula:bug/cannot_find_freefont

Conversation

@maciejkula

Copy link
Copy Markdown

Ensure that .add_flags is called for Freefont when building from source.

Otherwise we only look in ['/usr/local/include', '/usr/include', '.'], and none of these contain Freefont on Ubuntu 14.04.

Solves #3029.

@tacaswell

Copy link
Copy Markdown
Member

This is almost identical to #3032.

@maciejkula

Copy link
Copy Markdown
Author

You mean #3067 is almost identical to this? :)

Comment thread setupext.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this string 'test'?

@tacaswell

Copy link
Copy Markdown
Member

Details.....

@maciejkula

Copy link
Copy Markdown
Author

For the same reason why

ext = Extension('test', [])
ext.include_dirs.append(numpy.get_include())

has test in it --- no idea.

Jesting aside, I'm happy to close this in favour of #3067, looks better formatted anyway (and passes tests?).

@maciejkula maciejkula closed this May 19, 2014
@tacaswell

Copy link
Copy Markdown
Member

The other difference is that this PR calls pkg_config.setup_extension(ext, 'freetype2') which the other does not.

I would rather keep both open for now and close one once it is sorted out.

@tacaswell tacaswell reopened this May 19, 2014
@razius

razius commented May 24, 2014

Copy link
Copy Markdown
Contributor

Ah sorry, I didn't noticed that there was already a fix for the problem.

@tacaswell

Copy link
Copy Markdown
Member

@razius Could you explain the differences between the two patches?

@razius

razius commented May 29, 2014

Copy link
Copy Markdown
Contributor

Apart from some syntax differences this also calls the setup_extension method but that is also called by the add_flags method which is invoked afterwards so it ends up being called twice.

https://github.com/matplotlib/matplotlib/blob/master/setupext.py#L910

@tacaswell

Copy link
Copy Markdown
Member

Closed as #3067 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants