Repository navigation
Inline _calc_extents_from_path. - #29831
Merged
Merged
Conversation
The function can easily be inlined into its sole caller without affecting readability; this avoids having to lengthily document its inputs and outputs.
Contributor
|
I probably split this out in case it was used elsewhere, but that didn’t make it in the final code. I’m fine with inlining it |
scottshambaugh
approved these changes
Mar 31, 2025
QuLogic
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function can easily be inlined into its sole caller without affecting readability; this avoids having to lengthily document its inputs and outputs.
(This was introduced by @scottshambaugh in #29399 so perhaps he can comment on whether he planned to reuse the method elsewhere.)
PR summary
PR checklist