Repository navigation
[Bug Fix] Fix reverse mapping for _translate_tick_params - #29249
Merged
Merged
Conversation
timhoffm
approved these changes
Dec 7, 2024
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
Thanks for splitting.
Note: Test failures are unrelated.
Member
|
I thought we already had a PR for this; did it not get merged? |
Member
|
This fixes #27416, which does have two existing PRs but both seem to have stalled. |
rcomer
reviewed
Dec 7, 2024
2 of 5 tasks
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
rcomer
approved these changes
Dec 8, 2024
Member
|
Thanks @kyracho! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 8, 2024
…slate_tick_params
rcomer
added a commit
that referenced
this pull request
Dec 8, 2024
…249-on-v3.10.x Backport PR #29249 on branch v3.10.x ([Bug Fix] Fix reverse mapping for _translate_tick_params)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Hi. This fixes a bug in
_translate_tick_paramswhere some keys are not being mapped correctly withreverse=Trueandcls.axis_name = 'x'.For example, both 'left' and 'bottom' are mapped to 'tick1On', making the reverse ambiguous.
Separated from #28968 because this is an independent bug.
PR checklist