Skip to content

Fixes AIX internal CI build break.#29022

Merged
greglucas merged 1 commit into
matplotlib:mainfrom
KamathForAIX:main
Oct 29, 2024
Merged

Fixes AIX internal CI build break.#29022
greglucas merged 1 commit into
matplotlib:mainfrom
KamathForAIX:main

Conversation

@KamathForAIX

@KamathForAIX KamathForAIX commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

Closes #29020.

PR summary

PR checklist

github-actions[bot]
github-actions Bot reviewed Oct 25, 2024
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@oscargus oscargus added CI: Run cibuildwheel Run wheel building tests on a PR CI: Run cygwin Run cygwin tests on a PR labels Oct 25, 2024
@tacaswell tacaswell added this to the v3.10.0 milestone Oct 25, 2024
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 25, 2024
@tacaswell

tacaswell commented Oct 25, 2024

Copy link
Copy Markdown
Member

marked as release critical so we don't do 3.10 without fixing AIX>

@QuLogic

QuLogic commented Oct 25, 2024

Copy link
Copy Markdown
Member

Note that this is not AIX specific; it is about building against (newer) system FreeType.

@greglucas greglucas merged commit 9066b40 into matplotlib:main Oct 29, 2024
@greglucas

greglucas commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

Thanks @KamathForAIX!

@QuLogic, would it be worth having some kind of smoke-test in the CI for the newest freetype release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tacaswell tacaswell tacaswell approved these changes

@greglucas greglucas greglucas approved these changes

Assignees

No one assigned

Labels

CI: Run cibuildwheel Run wheel building tests on a PR CI: Run cygwin Run cygwin tests on a PR Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/fonts

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

AIX internal CI build break #Matplotlib

5 participants

@KamathForAIX @tacaswell @QuLogic @greglucas @oscargus