Repository navigation
Handle divergent colormaps and improve singular value handling in colorbars - #28999
Closed
ebarcelosf wants to merge 0 commit into
Closed
ebarcelosf wants to merge 0 commit into
ebarcelosf wants to merge 0 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
timhoffm
marked this pull request as draft
October 21, 2024 08:05
ebarcelosf
force-pushed
the
main
branch
2 times, most recently
from
November 9, 2024 20:13
cf1b881 to
9897de2
Compare
github-actions
Bot
added
topic: text
topic: mpl_toolkit
topic: rcparams
GUI: Qt
GUI: wx
GUI: gtk
GUI: MacOSX
GUI: tk
backend: agg
topic: animation
topic: path handling
backend: ps
backend: pdf
backend: svg
GUI: webagg
topic: categorical
topic: pyplot API
topic: ticks axis labels
topic: images
topic: text/fonts
topic: text/mathtext
topic: collections and mappables
and removed
topic: mpl_toolkit
labels
github-actions
Bot
removed
topic: rcparams
GUI: Qt
GUI: wx
GUI: gtk
GUI: MacOSX
GUI: tk
backend: agg
topic: animation
topic: path handling
backend: ps
backend: pdf
backend: svg
GUI: webagg
topic: categorical
topic: pyplot API
topic: ticks axis labels
topic: images
topic: text/fonts
topic: text/mathtext
topic: collections and mappables
topic: contour
topic: table
topic: axes
topic: figures and subfigures
CI: Run cibuildwheel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updates made in the code improve handling of two key cases:
coolwarmorRdBu, singular values (wherevmin == vmax) now collapse to the center, ensuring smoother transitions, addressing Tim's concern.vminandvmaxif they are equal, avoiding abrupt changes and maintaining consistent behavior, without triggering warnings.These changes enhance flexibility and consistency across different colormap types.
Helps with issue #26307
PR checklist