Skip to content

dynamic mapping configuration for issue #28772 #28776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crspencer11 wants to merge 2 commits into from
Closed

dynamic mapping configuration for issue #28772 #28776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ace57bc
dynamic mapping configuration for issue #28772
crspencer11 Sep 2, 2024
0d87a5e
change static method to include references to object params, namely a…
crspencer11 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions lib/matplotlib/axis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,8 +1066,7 @@ def get_tick_params(self, which='major'):
)
return self._translate_tick_params(self._minor_tick_kw, reverse=True)

@staticmethod
def _translate_tick_params(kw, reverse=False):
def _translate_tick_params(self, kw, reverse=False):
"""
Translate the kwargs supported by `.Axis.set_tick_params` to kwargs
supported by `.Tick._apply_params`.
Expand Down Expand Up @@ -1099,15 +1098,27 @@ def _translate_tick_params(kw, reverse=False):
'length': 'size',
'direction': 'tickdir',
'rotation': 'labelrotation',
'left': 'tick1On',
'bottom': 'tick1On',
'right': 'tick2On',
'top': 'tick2On',
'labelleft': 'label1On',
'labelbottom': 'label1On',
'labelright': 'label2On',
'labeltop': 'label2On',
}

# axis specific mappings
axis_mappings = {
'x': {
'top': 'tick2On',
'bottom': 'tick1On',
'labelbottom': 'label1On',
'labeltop': 'label2On',
},
'y': {
'left': 'tick1On',
'right': 'tick2On',
'labelleft': 'label1On',
'labelright': 'label2On',
}
}

# merge shared keymap pais with axis specific map
keymap.update(axis_mappings.get(self.axis_name, {}))

if reverse:
kwtrans = {
oldkey: kw_.pop(newkey)
Expand Down