Repository navigation
dynamic mapping configuration for issue #28772 - #28776
crspencer11 wants to merge 2 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
The CI complains as you have tabs and we use spaces, but that should be an easy fix. The code looks good otherwise. If you can please add a test that checks that the outcome is at expected, it would be great! In that way we can avoid breaking it later... |
Fixed the first issue as I forgot to install pre-commit checks. The testing, however, is throwing this error: ImportError: cannot import name '_c_internal_utils' from 'matplotlib' from lib/matplotlib/init.py. I am perhaps missing a compiler installation? Also, after recommitting, you can see many of the failed jobs errored on some sort of OS jobs. Is there some sort of container that I have to spin up? |
| 'top': 'tick20n', | ||
| 'bottom': 'tick10n', | ||
| 'labelbottom': 'label10n', | ||
| 'labeltop': 'label20n', | ||
| }, | ||
| 'y': { | ||
| 'left': 'tick10n', | ||
| 'right': 'tick20n', | ||
| 'labelleft': 'label10n', | ||
| 'labelright': 'label20n', |
There was a problem hiding this comment.
You have replaced all the "O"s here with zeros. I think that is why the tests are failing.
There was a problem hiding this comment.
Sorry, I should probably have given more explanation here.
You can see the details of the failures by clicking the "details" link on the right of any of the failed jobs below. The actual failure line looks like this. The values in this dictionary ultimately get passed as keywords to the Tick constructor, but since you change the spelling (replacing the letter 'O' with a zero) they are not recognised keywords so end up in kwargs. Everything in kwargs gets shortened and passed to the Line2D constructor, where it is also not recognised, hence the error.
|
crspencer11#1 |
not quite sure what this accomplishes? if it is to fix the linting issue with tabs over spaces I already recommitted that after installing pre-commits. |
since you mistakenly modified variable names, that pr reverts it. The names of variables are
|
|
Note, I have updated the linked issue to an older one, as the recent one was flagged as a duplicate. |
I see |
67d1da7 to
0d87a5e
Compare
|
Closing in favour of #29249. |
PR summary
Closes #27416: static method axes.get_tick_params() never returned labelbottom or labeltop. Fixed by dynamically updating shared key-value pairs with axis specific ones.
PR checklist