Skip to content

DOC: Fix version switcher for stable docs - #28512

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-stable
Jul 6, 2024
Merged

QuLogic merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-stable

Conversation

@QuLogic

@QuLogic QuLogic commented Jul 5, 2024

Copy link
Copy Markdown
Member

PR summary

This should stop the banner from showing up on stable.

PR checklist

This should stop the banner from showing up on stable.
@story645

story645 commented Jul 5, 2024 •

Copy link
Copy Markdown
Member

Is this what's supposed to be fixed? And can it only be fixed after merging? This is taken from the artifacts job on this PR:

Screenshot_20240705-171051.png

@QuLogic

QuLogic commented Jul 5, 2024

Copy link
Copy Markdown
Member Author

Yea, it won't be fixed until merged, as everything pulls that json file from devdocs.

@story645 story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merging cause I'm confused how merging to main fixes issues w/ 3.9 docs - is this supposed to be backported-but I figure @QuLogic knows the answer to this.

@QuLogic

QuLogic commented Jul 6, 2024

Copy link
Copy Markdown
Member Author

All docs pull switcher.json from devdocs; there's no need to backport. The version just needs to match.

@QuLogic
QuLogic merged commit 9f31b01 into matplotlib:main Jul 6, 2024
@QuLogic QuLogic added this to the v3.10.0 milestone Jul 6, 2024
@QuLogic
QuLogic deleted the fix-stable branch July 6, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants