Repository navigation
MNT: Update basic units example to work with numpy 2.0 - #28441
Merged
Merged
Conversation
There are new keyword arguments required for __array__ and __array_wrap__ that are expected in numpy 2.0.
story645
approved these changes
Jun 23, 2024
Member
|
@meeseeksdev backport to v3.9.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 24, 2024
… with numpy 2.0
rcomer
added a commit
that referenced
this pull request
Jun 24, 2024
…441-on-v3.9.x Backport PR #28441 on branch v3.9.x (MNT: Update basic units example to work with numpy 2.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
We are getting reviewdog failures in the galleries/examples tests with numpy 2.0. There are new keyword arguments required for array and array_wrap that are expected in numpy 2.0.
From the release notes https://numpy.org/devdocs/release/2.0.0-notes.html
https://numpy.org/devdocs/release/2.0.0-notes.html#the-array-special-method-now-takes-a-copy-keyword-argument
PR checklist