Skip to content

Fix Circle yaml line length - #28425

Merged
ksunden merged 1 commit into
matplotlib:mainfrom
rcomer:circle-ci-line-length
Jun 19, 2024
Merged

ksunden merged 1 commit into
matplotlib:mainfrom
rcomer:circle-ci-line-length

Conversation

@rcomer

@rcomer rcomer commented Jun 19, 2024

Copy link
Copy Markdown
Member

PR summary

#28413 introduced a pre-commit failure for the line length, that we missed amongst all the other CI failures.

PR checklist

@rcomer rcomer added the Documentation: build building the docs label Jun 19, 2024
@rcomer rcomer added this to the v3.9.1 milestone Jun 19, 2024
@ksunden
ksunden merged commit 603001f into matplotlib:main Jun 19, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 19, 2024
@ksunden

ksunden commented Jun 19, 2024 •

Copy link
Copy Markdown
Member

Hmmm... this worked here in the PR, but failed with "unable to find version \n" once merged... that is

I note that the newline is included in the error message, which is likely important.

I believe that since it is triggered by [status] the version on main is always the one that is run, which makes changing it challenging since it can't be tested without merging...

@ksunden ksunden mentioned this pull request Jun 19, 2024
5 tasks
@rcomer
rcomer deleted the circle-ci-line-length branch June 19, 2024 20:22
ksunden added a commit that referenced this pull request Jun 21, 2024
…425-on-v3.9.x

Backport PR #28425 on branch v3.9.x (Fix Circle yaml line length)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation: build building the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants