DOC: clarify no-build-isolation & mypy ignoring new functions #28282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
May 23, 2024
story645
force-pushed
the
contribute-mypy-build
branch
from
06bf31d to
ceb7460
Compare
story645
force-pushed
the
contribute-mypy-build
branch
from
ceb7460 to
5da84ba
Compare
story645
force-pushed
the
contribute-mypy-build
branch
from
5da84ba to
bf3560f
Compare
story645
force-pushed
the
contribute-mypy-build
branch
from
bf3560f to
81a22be
Compare
Member
Author
|
Failure is unrelated and I think I made the requested changes. |
timhoffm
approved these changes
Jun 24, 2024
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Take or leave the suggestion.
timhoffm
reviewed
Jun 24, 2024
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Tried to clean up the explanation of build isolation a bit based on #28091 (comment) and added notes about mypy not picking up new functions b/c that's confused contributors in the past.
PR checklist