Repository navigation
DOC: Add more 3D plot types - #28243
Merged
Merged
Conversation
scottshambaugh
marked this pull request as ready for review
May 17, 2024 06:08
scottshambaugh
force-pushed
the
3d_plot_types
branch
from
May 17, 2024 06:11
174ed1e to
014e434
Compare
timhoffm
reviewed
May 17, 2024
| @@ -0,0 +1,27 @@ | |||
| """ | |||
| ================ | |||
| plot(xs, ys, zs) | |||
Member
There was a problem hiding this comment.
Suggested change
| plot(xs, ys, zs) | |
| plot(x, y, z) |
For consistency. Best also change the variable names below.
oh, I see, the existing scatter() was using this convention, but that's really the odd ball and should be changed as well.
Contributor
Author
There was a problem hiding this comment.
The Axes3D.plot function has xs, ys, and zs as the argument names, I figure it's best to be consistent with that?
https://matplotlib.org/stable/api/_as_gen/mpl_toolkits.mplot3d.axes3d.Axes3D.plot.html#mpl_toolkits.mplot3d.axes3d.Axes3D.plot
Contributor
Author
There was a problem hiding this comment.
Add it to the list of annoying API inconsistencies
timhoffm
approved these changes
May 17, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 17, 2024
timhoffm
added a commit
that referenced
this pull request
May 17, 2024
…243-on-v3.9.x Backport PR #28243 on branch v3.9.x (DOC: Add more 3D plot types)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
We were missing a good number of 3D plot types on this page: https://matplotlib.org/stable/plot_types/
I added examples for
plot,quiver,bar3d, andstem.PR checklist