Repository navigation
Fix: [Bug]: Setting norm by string doesn't work for hexbin #28105 - #28106
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thank you for working on this! I think you need to do atleast two more things:
|
|
I squashed as you said, but I don't really know where add this tests, as I'm a new contributor. |
|
That code (along with probably checking the type of Putting the new test near matplotlib/lib/matplotlib/tests/test_axes.py Lines 969 to 978 in 199c31f test_hexbin_string_norm
|
|
Content of the test looks good! However, the linter needs to be placated. |
|
Sorry for the wait, it should be good now. |
|
I'm going to merge over the broken docs (it is an install issue that I think we have fixed on main). |
|
Thank you for your work on this @clementgilli and congratulations on your first merged Matplotlib PR 🎉 I hope we hear from you again. |
PR summary
The problem was that the methods on the norm were called directly on a string instead of the object itself.
So I put this block after `collection.set_norm(norm) in order to call the norm's getter.
Seems to solve the issue.
PR checklist