Skip to content

DOC: Clarify merge policy - #28046

Merged
rcomer merged 2 commits into
matplotlib:mainfrom
timhoffm:doc-clarify-merge-policy
May 9, 2024
Merged

rcomer merged 2 commits into
matplotlib:mainfrom
timhoffm:doc-clarify-merge-policy

Conversation

@timhoffm

@timhoffm timhoffm commented Apr 8, 2024

Copy link
Copy Markdown
Member

Inspired by questions on some edge cases in the past (e.g. #28043 (review)).

One of the approvers should be @tacaswell .

@timhoffm
timhoffm requested a review from tacaswell April 8, 2024 12:06
@github-actions github-actions Bot added the Documentation: devdocs files in doc/devel label Apr 8, 2024
@timhoffm
timhoffm force-pushed the doc-clarify-merge-policy branch from 5266d93 to 1aa9722 Compare April 8, 2024 12:08
@timhoffm timhoffm added this to the v3.10.0 milestone Apr 8, 2024
@timhoffm
timhoffm force-pushed the doc-clarify-merge-policy branch 2 times, most recently from fc19cfc to 10cc1b5 Compare April 8, 2024 12:22

@story645 story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly copy editing nits, I'm staying out of the review process for this.

Comment thread doc/devel/pr_guide.rst Resolved
Comment thread doc/devel/pr_guide.rst Resolved
Comment thread doc/devel/pr_guide.rst Resolved
Comment thread doc/devel/pr_guide.rst Resolved
@timhoffm
timhoffm force-pushed the doc-clarify-merge-policy branch from 10cc1b5 to 07906dd Compare April 8, 2024 20:17
Comment thread doc/devel/pr_guide.rst Resolved
Comment thread doc/devel/pr_guide.rst Resolved
@timhoffm

timhoffm commented May 5, 2024

Copy link
Copy Markdown
Member Author

ping

@tacaswell

Copy link
Copy Markdown
Member

It is docs, but I would like a second review on this.

@rcomer

rcomer commented May 6, 2024

Copy link
Copy Markdown
Member

I think this needs a rebase to pick up #28094.

timhoffm and others added 2 commits May 6, 2024 21:38
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
@timhoffm
timhoffm force-pushed the doc-clarify-merge-policy branch from 9bc06ca to 11de885 Compare May 6, 2024 19:39
@rcomer

rcomer commented May 8, 2024

Copy link
Copy Markdown
Member

Possibly tangential to this PR but

to do so, they should ping all core devs both on GitHub and on the dev
mailing list, and label the PR with the "Merge with single review?" label.

I am not on any dev mailing list. Should I be?

@story645

story645 commented May 8, 2024 •

Copy link
Copy Markdown
Member

I am not on any dev mailing list. Should I be?

Couldn't hurt, it's https://mail.python.org/mailman/listinfo/matplotlib-devel

which follow up would maybe be cross linking to the mailing list list :ref:`mailing-lists`

@rcomer rcomer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is clear and very welcome.

@rcomer

rcomer commented May 9, 2024

Copy link
Copy Markdown
Member

Apologies for the tangent. Because of the context my brain went “wait, is there a mailing list for core devs?”

@rcomer
rcomer merged commit d67f08e into matplotlib:main May 9, 2024
@timhoffm
timhoffm deleted the doc-clarify-merge-policy branch May 9, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation: devdocs files in doc/devel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants