Fixing Issue #21879: Changed int to round to help with floating point issue - #27473
Open
iimimii wants to merge 6 commits into
Open
Fixing Issue #21879: Changed int to round to help with floating point issue#27473iimimii wants to merge 6 commits into
iimimii wants to merge 6 commits into
Conversation
Member
|
As with #8265 I expect this to change out put images. |
dstansby
changed the title
Contributor
|
Per my thoughts in #8265 (comment), I suggest closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
For this issue: #21879
However, I reached an issue with purging the development environment. The development environment folder no longer showed up on my local computer, but was still showing in the GitHub repo in the pull request. When I continued to try and remove the environment I was not able to make any more commits. So I decided to reclone the repo and fix the code without setting up a development environment.
The original issue was a valueError that was caused by incorrect rounding of array values. In order to fix the rounding bug, we changed the int casting into round instead. This should solve the rounding bug and improve functionality of matplotlib.
Update
Received a comment about generating the same output images. I attempted casting the rounded values back into the int type to hopefully prevent images from generating differently. I also removed np.ciel from line 102 of the code.
PR checklist