Fixing Issue #21879 Changed int to round in backend_agg.py - #27465
Fixing Issue #21879 Changed int to round in backend_agg.py#27465iimimii wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
tacaswell
left a comment
There was a problem hiding this comment.
Please purge the virtual enviromnent from the checkin.
|
@tacaswell How do you purge the virtual environment from the checkin? |
|
Hello just following up, ran rm -r for my development environment. The folder no longer shows up on my local, but I is still showing in my pull request? Let me know if you have encountered this situation before. Thank you very much. |
|
I think you needed |
PR summary
This Pull Request attempts to fix the issue described in issue #21879. There was a rounding bug, and we changed the int casting into round instead. This should solve the rounding bug and improve functionality of matplotlib.
#21879