Skip to content

Fixing Issue #21879 Changed int to round in backend_agg.py - #27465

Closed
iimimii wants to merge 2 commits into
matplotlib:mainfrom
oliviavanzandt:mimip5
Closed

Fixing Issue #21879 Changed int to round in backend_agg.py#27465
iimimii wants to merge 2 commits into
matplotlib:mainfrom
oliviavanzandt:mimip5

Conversation

@iimimii

@iimimii iimimii commented Dec 7, 2023

Copy link
Copy Markdown

PR summary

This Pull Request attempts to fix the issue described in issue #21879. There was a rounding bug, and we changed the int casting into round instead. This should solve the rounding bug and improve functionality of matplotlib.
#21879

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please purge the virtual enviromnent from the checkin.

@oliviavanzandt

Copy link
Copy Markdown

@tacaswell How do you purge the virtual environment from the checkin?

@iimimii

iimimii commented Dec 8, 2023

Copy link
Copy Markdown
Author

Hello just following up, ran rm -r for my development environment. The folder no longer shows up on my local, but I is still showing in my pull request? Let me know if you have encountered this situation before. Thank you very much.

@rcomer

rcomer commented Dec 8, 2023

Copy link
Copy Markdown
Member

I think you needed git rm, but I see you have opened a new PR, so let's close this in favour of #27473.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants